libexpr: move ExprConcatStrings data to Exprs::alloc #14454
Merged
+15
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radvendii
force-pushed
the
exprconcatstrings-alloc
branch
from
60fa560 to
ffd6a94
Compare
xokdvium
reviewed
Nov 3, 2025
Radvendii
force-pushed
the
exprconcatstrings-alloc
branch
from
c508237 to
69fa3df
Compare
Ericson2314
reviewed
Nov 3, 2025
ExprConcatStrings no longer consumes the vector argument Co-authored-by: John Ericson <[email protected]>
Radvendii
force-pushed
the
exprconcatstrings-alloc
branch
from
5b6502d to
631fb6c
Compare
Ericson2314
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
this PR moves ExprConcatStrings' data to Exprs::alloc, and saves 16 bytes perExprConcatStringsstd::vector(24 bytes) ->uint16_t(fits in padding) + pointer (8 bytes)UPDATE: saves 8 bytes.
std::vector(24 bytes) -> 16 bytes (std::span)Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.